In Shariah it is strictly forbidden to make and capture pictures of living beings. In this regard following are few Hadiths of Prophet ﷺ.
1. On the judgement day, the roughest punishment (Azaab) will be given to the person who made pictures (Sahih Bukhari).
2. The Angels of Blessings do not enter a house where there is picture of a living being (Sahih Bukhari).
Therefore, due to these restrictions without any dire need, making pictures and earning from them both are forbidden (haram).
However, according to some scholars, till the time, shapes visible only on screen may not be printed or embossed on a solid surface are not in the ruling of picture. Therfore, if a job is only making digital pictures (photos) it may not be regarded as Haram. Therefore, it is not good to carry on this profession.
Another point must be cleared here,  that the photo of digital camera that is allowed means taking photo of that particular object that is also allowed to see without photo. Nevertheless, if the object is not allowed to see then its digital photo is also not allowed to make. Therefore if a person job is making digital photos of ladies or vulgar photos then this job and income both are forbidden (Haram).